Re: [PATCH nft] evalute: don't BUG on unexpected base datatype

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 13, 2025 at 04:46:06PM +0200, Florian Westphal wrote:
> Included bogo will cause a crash but this is the evaluation
> stage where we can just emit an error instead.
> 
> Signed-off-by: Florian Westphal <fw@xxxxxxxxx>
> ---
>  I wonder if we should just replace all BUGs in evaluate.c
>  with expr_error() calls, it avoids constant whack-a-mole.

I guess the expectation was that bison catches these but I fear JSON
parser has weakened that quite a bit.

I wish libnftables to well-behave in error cases unless critical ones
like ENOMEM.

Cheers, Phil




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux