Yi Chen <yiche@xxxxxxxxxx> wrote: > > Is tcpdump a requirement? AFAICS the dumps are only used > > as a debug aid when something goes wrong? > tcpdump is widely used in our LNST test cases. for example check if > one packet got modified. > Is it bad to use in upstream tests? If you still feel strange, I can > remove the tcpdump check. No need, you can keep tcpdump around. > What I care about most is whether the ruleset in the test is > configured correctly. > One only needs to NAT the control connection — the data connection > will be NATed automatically. I'd have expected that the ftp connection would fail in case there is a problem with NAT. But if you prefer to also validate via tcpdump thats fine. Thanks for v2, I will have a look.
