Re: [PATCH net-next 06/26] netfilter: nf_tables: nft_fib: consistent l3mdev handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 23, 2025 at 08:35:24AM +0100, Simon Horman wrote:
> On Thu, May 22, 2025 at 06:52:18PM +0200, Pablo Neira Ayuso wrote:
> > @@ -39,6 +40,21 @@ static inline bool nft_fib_can_skip(const struct nft_pktinfo *pkt)
> >  	return nft_fib_is_loopback(pkt->skb, indev);
> >  }
> >  
> > +/**
> > + * nft_fib_l3mdev_get_rcu - return ifindex of l3 master device
> 
> Hi Pablo,
> 
> I don't mean to hold up progress of this pull request. But it would be nice
> if at some point the above could be changed to
> nft_fib_l3mdev_master_ifindex_rcu so it matches the name of the function
> below that it documents.
> 
> Flagged by ./scripts/kernel-doc -none

Thanks for letting me know, I can resubmit the series, let me know.




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux