Re: [RESEND PATCH 1/1] netfilter: load nf_log_syslog on enabling nf_conntrack_log_invalid

[Lance Yang <lance.yang@xxxxxxxxx>]

On 2025/5/22 14:53, Lance Yang wrote:
> On 2025/5/22 14:34, Florian Westphal wrote:
> > Lance Yang <lance.yang@xxxxxxxxx> wrote:
> > > Nice, thanks for jumping in! I'll hold until the helper lands, then
> > > rebase and send the v2.
> >
> > Please just add this new helpre yourself in v2.

Does this helper look correct?

/**
 * nf_log_is_registered - Check if NF_LOG is registered for a protocol
 * family
 *
 * @pf: protocol family (e.g., NFPROTO_IPV4)
 *
 * Returns true if NF_LOG is registered, false otherwise.
 */
bool nf_log_is_registered(int pf)
{
        struct nf_logger *logger;

        logger = nf_logger_find_get(pf, NF_LOG_TYPE_LOG);
        if (logger) {
                nf_logger_put(pf, NF_LOG_TYPE_LOG);
                return true;
        }

        logger = nf_logger_find_get(pf, NF_LOG_TYPE_ULOG);
        if (logger) {
                nf_logger_put(pf, NF_LOG_TYPE_ULOG);
                return true;
        }

        return false;
}

Thanks,
Lance

> Ah, got it. I'll do that.
>
> Thanks,
> Lance