Re: [PATCH nf-next] selftests: netfilter: nft_concat_range.sh: add coverage for 4bit group representation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue,  6 May 2025 15:07:11 +0200
Florian Westphal <fw@xxxxxxxxx> wrote:

> Pipapo supports a more compact '4 bit group' format that is chosen when
> the memory needed for the default exceeds a threshold (2mb).
> 
> Add coverage for those code paths, the existing tests use small sets that
> are handled by the default representation.
> 
> This comes with a test script run-time increase, but I think its ok:
> 
>  normal: 2m35s -> 3m9s
>  debug:  3m24s -> 5m29s (with KSFT_MACHINE_SLOW=yes).
> 
> Cc: Stefano Brivio <sbrivio@xxxxxxxxxx>
> Signed-off-by: Florian Westphal <fw@xxxxxxxxx>

I hope you didn't find further matching issues with this, but surely
the new tests are better than hoping...

Reviewed-by: Stefano Brivio <sbrivio@xxxxxxxxxx>

-- 
Stefano





[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux