Hi Jeremy,
Sorry for the extremely long delay: your patches were set aside then were
forgotten. Both of your patches are applied.
Best regards,
Jozsef
On Fri, 7 Feb 2025, Jeremy Sowden wrote:
> There is a syntax error in a redirection:
>
> $ bash -x utils/ipset_bash_completion/ipset
> + shopt -s extglob
> utils/ipset_bash_completion/ipset: line 365: syntax error near unexpected token `('
> utils/ipset_bash_completion/ipset: line 365: `done < <(PATH=${PATH}:/sbin ( command ip -o link show ) 2>/dev/null)'
>
> Move the environment variable assignment into the sub-shell.
>
> This fix was previously applied in commit 417ee1054fb2 ("bash-completion:
> fix syntax error"), but then reverted, presumably by mistake, in commit
> 0378d91222c1 ("Bash completion utility updated").
>
> Fixes: 0378d91222c1 ("Bash completion utility updated")
> Signed-off-by: Jeremy Sowden <jeremy@xxxxxxxxxx>
> ---
> utils/ipset_bash_completion/ipset | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utils/ipset_bash_completion/ipset b/utils/ipset_bash_completion/ipset
> index d258be234806..fc95d4043865 100644
> --- a/utils/ipset_bash_completion/ipset
> +++ b/utils/ipset_bash_completion/ipset
> @@ -362,7 +362,7 @@ _ipset_get_ifnames() {
> while read -r; do
> REPLY="${REPLY#*: }"
> printf "%s\n" ${REPLY%%:*}
> -done < <(PATH=${PATH}:/sbin ( command ip -o link show ) 2>/dev/null)
> +done < <(( PATH=${PATH}:/sbin command ip -o link show ) 2>/dev/null)
> }
>
> _ipset_get_iplist() {
> --
> 2.47.2
>
>
>
--
E-mail : kadlec@xxxxxxxxxxxxx, kadlec@xxxxxxxxxxxxxxxxx, kadlecsik.jozsef@xxxxxxxxx
Address: Wigner Research Centre for Physics
H-1525 Budapest 114, POB. 49, Hungary
