On Tue, Apr 08, 2025 at 04:24:24PM +0200, Eric Woudstra wrote: > Jakub Kicinski suggested following patch: > > W=1 C=1 GCC build gives us: > > net/bridge/netfilter/nf_conntrack_bridge.c: note: in included file (through > ../include/linux/if_pppox.h, ../include/uapi/linux/netfilter_bridge.h, > ../include/linux/netfilter_bridge.h): include/uapi/linux/if_pppox.h: > 153:29: warning: array of flexible structures > > It doesn't like that hdr has a zero-length array which overlaps proto. > The kernel code doesn't currently need those arrays. > > PPPoE connection is functional after applying this patch. > > Reviewed-by: Nikolay Aleksandrov <razor@xxxxxxxxxxxxx> > Signed-off-by: Eric Woudstra <ericwouds@xxxxxxxxx> Reviewed-by: Kees Cook <kees@xxxxxxxxxx> -- Kees Cook
