Stefano Brivio <sbrivio@xxxxxxxxxx> wrote: > This made me wonder if there's any specific reason why we would need > #if defined(x) here instead of a common #ifdef x. It looks like there > isn't a reason, so maybe #ifdef CONFIG_DEBUG_NET is more... expected. Ok, I'll change it and will also update the rest as per your comments. Not sure I will be able to spin v2 before next week though. > Perhaps those could all be uint16_t to reflect that it's YMM registers, > and nft_pipapo_avx2_debug_usable() could simply promote them to > unsigned long as needed by test_bit(). I'll swich to u16 and will ditch test_bit in favor of BIT(a) & r->. > They could even be uint32_t to represent ZMM registers (or extended > YMM) if we want to make this AVX512-ready, I'm not sure. Can be done later.
