assert() logic is reversed, all expressions in the list are handled,
including the first.
src/expression.c:1285: list_expr_to_binop: Assertion `first' failed.
Fixes: 53d6bb992445 ("expression: initialize list of expression to silence gcc compile warning")
Reported-by: Florian Westphal <fw@xxxxxxxxx>
Signed-off-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
---
src/expression.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/expression.c b/src/expression.c
index 228754fc2067..cc693b10d759 100644
--- a/src/expression.c
+++ b/src/expression.c
@@ -1282,7 +1282,7 @@ struct expr *list_expr_to_binop(struct expr *expr)
}
}
/* list with one single item only, this should not happen. */
- assert(first);
+ assert(!first);
/* zap list expressions, they have been moved to binop expression. */
init_list_head(&expr->expressions);
--
2.30.2
