On Wed, Mar 26, 2025 at 09:33:25PM +0100, Florian Westphal wrote: > Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > > EXPR_SET_ELEM_CATCHALL, > > - EXPR_FLAGCMP, > > EXPR_RANGE_VALUE, > > EXPR_RANGE_SYMBOL, > > > > - EXPR_MAX = EXPR_FLAGCMP > > + EXPR_MAX = EXPR_SET_ELEM_CATCHALL > > }; > > This is strange, why is EXPR_MAX not set to last expression? > > Perhaps this should be changed to __EXPR_MAX > #define EXPR_MAX (__EXPR_MAX-1) > > like we do elsewhere so this doesn't have to be > updated all the time? That's a good idea, I will send a v2 of this: https://patchwork.ozlabs.org/project/netfilter-devel/patch/20250326210511.188767-1-pablo@xxxxxxxxxxxxx/
