Corubba Smith <corubba@xxxxxx> wrote: > + if ((strlen(target_netns_path) > 0) && > + (join_netns_fd(source_netns_fd, NULL) != ULOGD_IRET_OK) > + ) { > + ulogd_log(ULOGD_FATAL, "error joining source network " > + "namespace\n"); > + goto out_handle; > + } > + source_netns_fd = -1; > + This looks buggy, but I do realize that join_netns_fd() closes this for us. Maybe a comment would help?