Re: [PATCH nft] expression: tolerate named set protocol dependency

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> > +			const struct expr *key = right->set->key;
> > +			struct expr *tmp;
> > +
> > +			tmp = constant_expr_alloc(&expr->location, key->dtype,
> > +						  key->byteorder, key->len,
> > +						  NULL);
> > +
> > +			ops->pctx_update(ctx, &expr->location, left, tmp);
> > +			expr_free(tmp);
> 
> maybe narrow down this to meta on the lhs? I am not sure of the effect
> of this update for payload and ct, they also provide .pctx_update.

Sure, I can amend it accordingly.

> If there is a use-case for these two other expression, this can be
> revisited.

Agreed, lets restrict it for meta for now.

Thanks for reviewing.




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux