Re: [PATCH libnetfilter_queue] src: doc: Re-order gcc args so nf-queue.c compiles on Debian systems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Pablo,

On Wed, Mar 19, 2025 at 10:28:52AM +0100, Pablo Neira Ayuso wrote:
> On Wed, Mar 19, 2025 at 11:56:05AM +1100, Duncan Roe wrote:
> > Change the order of gcc arguments following the discussion starting at
> > https://www.spinics.net/lists/netfilter-devel/msg90612.html.
> > While being about it, update the obsolete -ggdb debug option to -gdwarf-4.
> >
> > Reported-by: "G.W. Haywood" <ged@xxxxxxxxxxxxxxxxxx>
> > Fixes: f0eb6a9c15a5 ("src: doc: Update the Main Page to be nft-focussed")
> > Signed-off-by: Duncan Roe <duncan_roe@xxxxxxxxxxxxxxx>
> > ---
> >  src/libnetfilter_queue.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/libnetfilter_queue.c b/src/libnetfilter_queue.c
> > index f152efb..99799c0 100644
> > --- a/src/libnetfilter_queue.c
> > +++ b/src/libnetfilter_queue.c
> > @@ -86,7 +86,7 @@
> >   * nf-queue.c source file.
> >   * Simple compile line:
> >   * \verbatim
> > -gcc -g3 -ggdb -Wall -lmnl -lnetfilter_queue -o nf-queue nf-queue.c
> > +gcc -g3 -gdwarf-4 -Wall nf-queue.c -o nf-queue -lnetfilter_queue -lmnl
>
> I am going t remove -g3 and -gdwarf-4, so it ends up with:
>
> gcc -Wall nf-queue.c -o nf-queue -lnetfilter_queue -lmnl

That makes nonsense of the previous line:

| you should start by reading (or, if feasible, compiling and stepping through with gdb) nf-queue.c

You can only step through nf-queue.c if you compile with the debug options.

Please leave them there.

Cheers ... Duncan.




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux