Re: [PATCH ulogd2 2/3] gprint: fix comma after ip addresses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08.02.25 22:20, Pablo Neira Ayuso wrote:
> On Sat, Feb 08, 2025 at 02:49:49PM +0100, corubba wrote:
>> Gone missing in f04bf679.
>
> ulogd2$ git show f04bf679
> fatal: ambiguous argument 'f04bf679': unknown revision or path not in the working tree.
>
> ???

The full commit id is f04bf6794d1153abd2c3b0bfededd9403d79acf6, which
does exist [0]. And that `git show` command works in my local clone of
the repo, showing the commit in question.

[0] https://git.netfilter.org/ulogd2/commit/?id=f04bf679

>
>> Signed-off-by: Corubba Smith <corubba@xxxxxx>
>> ---
>>  output/ulogd_output_GPRINT.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/output/ulogd_output_GPRINT.c b/output/ulogd_output_GPRINT.c
>> index 37829fa..d95ca9d 100644
>> --- a/output/ulogd_output_GPRINT.c
>> +++ b/output/ulogd_output_GPRINT.c
>> @@ -179,9 +179,15 @@ static int gprint_interp(struct ulogd_pluginstance *upi)
>>  			if (!inet_ntop(family, addr, buf + size, rem))
>>  				break;
>>  			ret = strlen(buf + size);
>> +			rem -= ret;
>> +			size += ret;
>>
>> +			ret = snprintf(buf+size, rem, ",");
>> +			if (ret < 0)
>> +				break;
>>  			rem -= ret;
>>  			size += ret;
>> +
>>  			break;
>>  		}
>>  		default:
>> --
>> 2.48.1
>>
>>
>






[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux