On Sun, Jun 8, 2025 at 9:44 PM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>
> > +++ b/fs/iomap/buffered-io-bio.c
> > @@ -0,0 +1,291 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +
> > +#include <linux/bio.h>
>
> Please keep the copyrights from the original file.
>
> From a quick look the split looks a bit odd. But I'll wait for
> a version that I can apply and look at the result before juding
> it.
>
> > +void iomap_submit_bio(struct bio *bio)
> > +{
> > + submit_bio(bio);
> > +}
>
> This is an entirely new function and not just a code movement.
>
> Please add new abstractions independent of code movement.
>
I'll fix both of these in v2.
