On 05/06/2025 08:17, Christoph Hellwig wrote:
> Use xfs_readonly_buftarg instead of open coding it.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> fs/xfs/xfs_super.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 0bc4b5489078..bb0a82635a77 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -2020,14 +2020,13 @@ xfs_remount_rw(
> int error;
>
> if (mp->m_logdev_targp && mp->m_logdev_targp != mp->m_ddev_targp &&
> - bdev_read_only(mp->m_logdev_targp->bt_bdev)) {
> + xfs_readonly_buftarg(mp->m_logdev_targp)) {
> xfs_warn(mp,
> "ro->rw transition prohibited by read-only logdev");
> return -EACCES;
> }
>
> - if (mp->m_rtdev_targp &&
> - bdev_read_only(mp->m_rtdev_targp->bt_bdev)) {
> + if (mp->m_rtdev_targp && xfs_readonly_buftarg(mp->m_rtdev_targp)) {
> xfs_warn(mp,
> "ro->rw transition prohibited by read-only rtdev");
> return -EACCES;
Looks good to me.
Reviewed-by: Hans Holmberg <hans.holmberg@xxxxxxx>
