On 05/06/2025 08:16, Christoph Hellwig wrote:
> Ensure the file system hasn't been shut down before waiting for a free
> zone to become available, because that won't happen on a shut down
> file system. Without this processes can occasionally get stuck in
> the allocator wait loop when racing with a file system shutdown.
> This sporadically happens when running generic/388 or generic/475.
>
> Fixes: 4e4d52075577 ("xfs: add the zoned space allocator")
> Reported-by: Shinichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> fs/xfs/xfs_zone_alloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_zone_alloc.c b/fs/xfs/xfs_zone_alloc.c
> index 80add26c0111..0de6f64b3169 100644
> --- a/fs/xfs/xfs_zone_alloc.c
> +++ b/fs/xfs/xfs_zone_alloc.c
> @@ -727,7 +727,7 @@ xfs_select_zone(
> for (;;) {
> prepare_to_wait(&zi->zi_zone_wait, &wait, TASK_UNINTERRUPTIBLE);
> oz = xfs_select_zone_nowait(mp, write_hint, pack_tight);
> - if (oz)
> + if (oz || xfs_is_shutdown(mp))
> break;
> schedule();
> }
Looks good to me.
Reviewed-by: Hans Holmberg <hans.holmberg@xxxxxxx>
