Re: [PATCH 01/11] fuse: fix livelock in synchronous file put from fuseblk workers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 22 May 2025 at 02:02, Darrick J. Wong <djwong@xxxxxxxxxx> wrote:

> Fix this by only using synchronous fputs for fuseblk servers if the
> process doesn't have PF_LOCAL_THROTTLE.  Hopefully the fuseblk server
> had the good sense to call PR_SET_IO_FLUSHER to mark itself as a
> filesystem server.

The bug is valid.

I just wonder if we really need to check against the task flag instead
of always sending release async, which would simplify things.

The sync release originates from commit 5a18ec176c93 ("fuse: fix hang
of single threaded fuseblk filesystem"), but then commit baebccbe997d
("fuse: hold inode instead of path after release") made that obsolete.

Anybody sees a reason why sync release for fuseblk is a good idea?

Thanks,
Miklos




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux