On Wed, May 21, 2025 at 03:42:38PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@xxxxxxxxxx>
>
> I don't know why this change was made:
>
> iam=check
>
> to
>
> iam=check.$$
>
> The only users of this variable are:
>
> check:36:iam=check
> check:52:rm -f $tmp.list $tmp.tmp $tmp.grep $here/$iam.out $tmp.report.* $tmp.arglist
> common/btrfs:216: if [ "$iam" != "check" ]; then
> common/overlay:407: if [ "$iam" != "check" ]; then
> common/rc:3565: if [ "$iam" != "check" ]; then
> common/xfs:1021: if [ "$iam" != "check" ]; then
> new:9:iam=new
>
> None of them were ported to notice the pid. Consequently,
> _check_generic_filesystem (aka _check_test_fs on an ext4 filesystem)
> failing will cause ./check to exit the entire test suite when the test
> filesystem is corrupt. That's not what we wanted, particularly since
> Leah added a patch to repair the test filesystem between tests.
>
> Cc: <fstests@xxxxxxxxxxxxxxx> # v2024.12.08
> Fixes: fa0e9712283f0b ("fstests: check-parallel")
> Signed-off-by: "Darrick J. Wong" <djwong@xxxxxxxxxx>
> ---
I should revert this line too, when I removed privatens and run_setsid from check.
Thanks for this fixing.
Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx>
> check | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> diff --git a/check b/check
> index ede54f6987bcc3..826641268f8b52 100755
> --- a/check
> +++ b/check
> @@ -33,7 +33,7 @@ exclude_tests=()
> _err_msg=""
>
> # start the initialisation work now
> -iam=check.$$
> +iam=check
>
> # mkfs.xfs uses the presence of both of these variables to enable formerly
> # supported tiny filesystem configurations that fstests use for fuzz testing
>
>
