On Thu, May 01, 2025 at 08:42:44AM -0500, Christoph Hellwig wrote:
> Test that files written back after closing are packed tightly instead of
> using up open zone resources.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> tests/xfs/4206 | 57 ++++++++++++++++++++++++++++++++++++++++++++++
> tests/xfs/4206.out | 1 +
> 2 files changed, 58 insertions(+)
> create mode 100755 tests/xfs/4206
> create mode 100644 tests/xfs/4206.out
>
> diff --git a/tests/xfs/4206 b/tests/xfs/4206
> new file mode 100755
> index 000000000000..63e6aebeaeec
> --- /dev/null
> +++ b/tests/xfs/4206
> @@ -0,0 +1,57 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2024 Christoph Hellwig.
> +#
> +# FS QA Test No. 4206
> +#
> +# Test that data is packed tighly for writeback after the files were
> +# closed.
> +#
> +. ./common/preamble
> +_begin_fstest auto quick rw zone
> +
> +_cleanup()
> +{
> + cd /
> + _scratch_unmount >/dev/null 2>&1
Same, is this unmount necessary?
> +}
> +
> +# Import common functions.
> +. ./common/filter
> +
> +_require_scratch
> +
> +_filter_rgno()
If this filter is useful for 1+ case, how about moving it to common/filter?
Or remove the "_" prefix of a local function.
> +{
> + # the rg number is in column 4 of xfs_bmap output
> + perl -ne '
> + $rg = (split /\s+/)[4] ;
> + if ($rg =~ /\d+/) {print "$rg "} ;
> + '
> +}
> +
> +_scratch_mkfs_xfs >>$seqres.full 2>&1
> +_scratch_mount
> +_require_xfs_scratch_zoned
> +
> +# Create a bunch of small files
> +for i in `seq 1 100`; do
> + file=$SCRATCH_MNT/$i
> +
> + $XFS_IO_PROG -f -c 'pwrite 0 8k' $file >>$seqres.full
> +done
> +
> +sync
> +
> +# Check that all small files are placed together
> +short_rg=`xfs_bmap -v $SCRATCH_MNT/1 | _filter_rgno`
> +for i in `seq 2 100`; do
> + file=$SCRATCH_MNT/$i
> + rg=`xfs_bmap -v $file | _filter_rgno`
> + if [ "${rg}" != "${short_rg}" ]; then
> + echo "RG mismatch for file $i: $short_rg/$rg"
> + fi
> +done
> +
> +status=0
> +exit
> diff --git a/tests/xfs/4206.out b/tests/xfs/4206.out
> new file mode 100644
> index 000000000000..4835b5053ae5
> --- /dev/null
> +++ b/tests/xfs/4206.out
> @@ -0,0 +1 @@
> +QA output created by 4206
> --
> 2.47.2
>
>
