On the way back from meetings and long distance travel, so just chiming in with a few points. One is that the patch split still doesn't make sense to me. Patch 1 adds all the infrastructure which remains unused, and then patch 2 trivially wires it up. Please merge the two. > > Urk, linear search. Oh well, I guess we can switch to a hashtable if > > we get complaints about issues. > > Yea, if it's a problem I can implement an hashtable, from my local > testing using larger source directories (1.3mln inodes, ~400k hardlinks) > the difference was actually just a few seconds (given that most of the > time is doing i/o) Please add this to the commit log, it's always good to know about the trade offs and the data supporting it when later looking at the commit history.
