On Wed, Apr 30, 2025 at 08:35:34AM +0000, Hans Holmberg wrote: > + blk_mode_t mode; > > - *bdev_filep = bdev_file_open_by_path(name, > - BLK_OPEN_READ | BLK_OPEN_WRITE | BLK_OPEN_RESTRICT_WRITES, > - mp->m_super, &fs_holder_ops); > + mode = sb_open_mode(mp->m_super->s_flags); > + *bdev_filep = bdev_file_open_by_path(name, mode, > + mp->m_super, &fs_holder_ops); We don't really need the local variable for mode now. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>