Thanks Darrick for the review On Mon, Apr 28, 2025 at 10:23:55AM -0700, Darrick J. Wong wrote: > On Sat, Apr 26, 2025 at 03:55:35PM +0200, Luca Di Maio wrote: > > +Content, timestamps, attributes and extended attributes are preserved > > I thought this only preserved the atime and mtime timestamps? Right, I'll be more specific > > +for all file types. > > +.TP > > +.BI [file=] protofile > > +If the optional > > +.PD > > +.I prototype > > +argument is given, and it's a file, > > "If the optional prototype argument is given and points to a regular > file..." > > (I think, technically speaking, you store a protofile on a block device > and pass that in, but let's not encourage that kind of absurdity) Will modify, thanks > > +.B mkfs.xfs > > +uses it as a prototype file and takes its directions from that file. > > The blocks and inodes specifiers in the > > .I protofile > > are provided for backwards compatibility, but are otherwise unused. > > @@ -1136,8 +1145,16 @@ always terminated with the dollar ( > > .B $ > > ) token. > > .TP > > +.BI noatime= value > > +If set to 1, when we're populating the root filesystem from a directory ( > > +.B file=directory > > +option) > > +access times are NOT preserved and are set to the current time instead. > > +Set to 0 to preserve access times from source files. > > I would say "Set to 0 to copy access timestamps from source files". > > Though if the default is going to be "do not copy atime from sourcev > file" then the option to enable copying of atime ought to be named > "atime". I was also thinking `atime=1` would be better to not invert the logic, I was going with the `noatime` option for consistency with mount options, but I assume this has nothing to do with that, so we can use atime Will modify to be atime > > - > > Extraneous change? Yep sorry > > +/* populate from directory */ [-p dirname]\n\ > > /* populate from directory */ [-p dirname,noatime=0|1] > > --D Ack thanks
