Re: [PATCH 33/45] xfs_mkfs: reflink conflicts with zoned file systems for now

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 09, 2025 at 09:55:36AM +0200, Christoph Hellwig wrote:
> Until GC is enhanced to not unshared reflinked blocks we better prohibit
> this combination.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

...or gc figures out how to do reflinked moves.  Either way,
Reviewed-by: "Darrick J. Wong" <djwong@xxxxxxxxxx>

--D

> ---
>  mkfs/xfs_mkfs.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index 7d4114e8a2ea..0e351f9efc32 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -2957,6 +2957,14 @@ _("rt extent size not supported on realtime devices with zoned mode\n"));
>  			}
>  			cli->rtextsize = 0;
>  		}
> +		if (cli->sb_feat.reflink) {
> +			if (cli_opt_set(&mopts, M_REFLINK)) {
> +				fprintf(stderr,
> +_("reflink not supported on realtime devices with zoned mode specified\n"));
> +				usage();
> +			}
> +			cli->sb_feat.reflink = false;
> +		}
>  
>  		/*
>  		 * Force the rtinherit flag on the root inode for zoned file
> -- 
> 2.47.2
> 
> 




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux