On Wed, Apr 09, 2025 at 09:55:31AM +0200, Christoph Hellwig wrote:
> Don't look at the variable for the rtname command line option, but
> the actual file system geometry.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> repair/dinode.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/repair/dinode.c b/repair/dinode.c
> index 7bdd3dcf15c1..0c559c408085 100644
> --- a/repair/dinode.c
> +++ b/repair/dinode.c
> @@ -3265,8 +3265,9 @@ _("bad (negative) size %" PRId64 " on inode %" PRIu64 "\n"),
> flags &= XFS_DIFLAG_ANY;
> }
>
> - /* need an rt-dev for the realtime flag! */
> - if ((flags & XFS_DIFLAG_REALTIME) && !rt_name) {
> + /* need an rt-dev for the realtime flag */
> + if ((flags & XFS_DIFLAG_REALTIME) &&
> + !mp->m_rtdev_targp) {
If we're going to check the fs geometry, then why not check
mp->m_sb.sb_rextents != 0?
--D
> if (!uncertain) {
> do_warn(
> _("inode %" PRIu64 " has RT flag set but there is no RT device\n"),
> --
> 2.47.2
>
>
