Re: [PATCH] iomap: Rename iomap_last_written_block to iomap_first_unchanged_block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 27, 2025 at 01:57:06PM +0800, Chi Zhiling wrote:
> From: Chi Zhiling <chizhiling@xxxxxxxxxx>
> 
> This renames iomap_last_written_block() to iomap_first_unchanged_block()
> to better reflect its actual behavior of finding the first unmodified
> block after partial writes, improving code readability.

Does it?  I it used in the context of a write operation where uncached
is not exactly well define.  I'm not a native speaker, but I don't see
an improvement here (then again I picked the current name, so I might be
biassed).

> +static inline loff_t iomap_first_unchanged_block(struct inode *inode, loff_t pos,

Either way please avoid the overly long line.





[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux