On 3/21/25 9:28 AM, bodonnel@xxxxxxxxxx wrote: > From: Bill O'Donnell <bodonnel@xxxxxxxxxx> > > In certain cases, if a block is so messed up that crc, uuid and magic > number are all bad, we need to not only detect in phase3 but fix it > properly in phase6. In the current code, the mechanism doesn't work > in that it only pays attention to one of the parameters. > > Note: in this case, the nlink inode link count drops to 1, but > re-running xfs_repair fixes it back to 2. This is a side effect that > should probably be handled in update_inode_nlinks() with separate patch. > Regardless, running xfs_repair twice fixes the issue. Also, this patch > fixes the issue with v5, but not v4 xfs. Nitpick: IIRC V4 filesystems do not have UUIDs in metadata blocks, so I think this problem is unique to corrupted V5 filesystems. -Eric
