On Wed, Mar 19, 2025 at 07:31:13AM +0100, Christoph Hellwig wrote: > On Tue, Mar 18, 2025 at 11:40:47AM +0300, Dan Carpenter wrote: > > Hello Christoph Hellwig, > > > > Commit e2874632a621 ("xfs: use vmalloc instead of vm_map_area for > > buffer backing memory") from Mar 10, 2025 (linux-next), leads to the > > following Smatch static checker warning: > > Just a question to reconfirm how smatch works: the vm_unmap_ram > replaced by vfree in this patch also had a might_sleep(), so I think > this bug is older and the check should have also triggeted before. > Or am I missing something? Oh, yeah, sorry. It did trigger before but I never reported it. It only showed up as a new bug because the warning moved from xfs_buf_free_pages() to xfs_buf_free(). Sorry! regards, dan carpenter