Re: [PATCH v6 06/13] xfs: switch atomic write size check in xfs_file_write_iter()

Subject: Re: [PATCH v6 06/13] xfs: switch atomic write size check in xfs_file_write_iter()
From: John Garry <john.g.garry@xxxxxxxxxx>
Date: Mon, 17 Mar 2025 09:17:36 +0000
Cc: brauner@xxxxxxxxxx, djwong@xxxxxxxxxx, cem@xxxxxxxxxx, dchinner@xxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, ojaswin@xxxxxxxxxxxxx, ritesh.list@xxxxxxxxx, martin.petersen@xxxxxxxxxx, tytso@xxxxxxx, linux-ext4@xxxxxxxxxxxxxxx
In-reply-to: <20250317061817.GF27019@lst.de>
Organization: Oracle Corporation
References: <20250313171310.1886394-1-john.g.garry@oracle.com> <20250313171310.1886394-7-john.g.garry@oracle.com> <20250317061817.GF27019@lst.de>
User-agent: Mozilla Thunderbird

On 17/03/2025 06:18, Christoph Hellwig wrote:

switch seems like odd wording here (but then again I'm not a native
speaker).  What about something like "refine" instead?


Sure, I can change it


Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>



Thanks

References:
- [PATCH v6 00/13] large atomic writes for xfs with CoW
  - From: John Garry
- [PATCH v6 06/13] xfs: switch atomic write size check in xfs_file_write_iter()
  - From: John Garry
- Re: [PATCH v6 06/13] xfs: switch atomic write size check in xfs_file_write_iter()
  - From: Christoph Hellwig