On Wed, Mar 12, 2025 at 09:13:45AM +0000, John Garry wrote: > > > + if (error || (!*shared && !atomic_sw)) > > > > And it's pnly used once. Basically is is used to force COW, right? > > Yes, we force it. Indeed, I think that is term you used a long time ago in > your RFC for atomic file updates. > > But that flag is being used to set XFS_BMAPI_EXTSZALIGN, so feels like a bit > of a disconnect as why we would set XFS_BMAPI_EXTSZALIGN for "forced cow". I > would need to spell that out. Maybe use two flags for that even if they currently are set together? Note that this would go away if we'd always align extsize hinted allocations, which I suspect is a good idea (even if I'm not 100% sure about it).
