On Sun, Mar 09, 2025 at 09:11:50AM +0000, John Garry wrote: > On 08/03/2025 16:46, kernel test robot wrote: > >>> fs/xfs/xfs_file.c:746:15: error: too few arguments to function 'xfs_file_write_checks' > > 746 | ret = xfs_file_write_checks(iocb, from, &iolock); > > | ^~~~~~~~~~~~~~~~~~~~~ > > fs/xfs/xfs_file.c:434:1: note: declared here > > 434 | xfs_file_write_checks( > > | ^~~~~~~~~~~~~~~~~~~~~ > > Christoph's zoned series added a new arg to xfs_file_write_checks(). > > I think that we want to add a NULL here as that arg - assuming that we > won't support atomic writes for zoned devices now. > > Carlos, please advise to handle. I didn't know the bot was monitoring all branches, I just created this branch to open a discussion with you an Christoph. Well, I'll do that on my personal repo next time :) I'll figure out what to do with this today. > > Thanks, > John
