On Wed, Mar 05, 2025 at 04:35:34PM -0800, Christoph Hellwig wrote: > I gave it a quick try yesterday, but it turns out XFS hold the > invalidate_lock over dedup, and the readahead code also wants to > take it. So the simple use of the readahead code doesn't work. > But as dedup only needs a tiny subset of the readahead algorithm > it might be possible to simply open code it. I'll see what I can > do when I find a little more time for it. Thanks for looking into this. I figured I had to always do read() first to support older kernels anyway, but I guess it would be good to get this fixed for the point where today's kernels have become older kernels :-) (Perhaps this hasn't been noticed before since most deduplication software does its own read() and comparison before calling the ioctl? Just a guess.) /* Steinar */ -- Homepage: https://www.sesse.net/
