Re: [PATCH 13/27] xfs_repair: tidy up rmap_diffkeys

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 13/27] xfs_repair: tidy up rmap_diffkeys
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 6 Feb 2025 21:20:36 -0800
Cc: aalbersh@xxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx
In-reply-to: <173888088295.2741033.4604651348658562209.stgit@frogsfrogsfrogs>
References: <173888088056.2741033.17433872323468891160.stgit@frogsfrogsfrogs> <173888088295.2741033.4604651348658562209.stgit@frogsfrogsfrogs>

On Thu, Feb 06, 2025 at 02:53:07PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@xxxxxxxxxx>
> 
> Tidy up the comparison code in this function to match the kernel.

Looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Or do you want to use the fancy cmp_int() helper?

References:
- [PATCHSET v6.3 3/5] xfsprogs: realtime reverse-mapping support
  - From: Darrick J. Wong
- [PATCH 13/27] xfs_repair: tidy up rmap_diffkeys
  - From: Darrick J. Wong

Prev by Date: Re: [PATCH 12/27] xfs_spaceman: report health status of the realtime rmap btree
Next by Date: Re: [PATCH 14/27] xfs_repair: flag suspect long-format btree blocks
Previous by thread: [PATCH 13/27] xfs_repair: tidy up rmap_diffkeys
Next by thread: [PATCH 14/27] xfs_repair: flag suspect long-format btree blocks
Index(es):
- Date
- Thread

[Index of Archives] [XFS Filesystem Development (older mail)] [Linux Filesystem Development] [Linux Audio Users] [Yosemite Trails] [Linux Kernel] [Linux RAID] [Linux SCSI]

Powered by Linux