Re: [PATCH 1/2] xfs: track the number of blocks in each buftarg

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 26, 2025 at 03:42:48PM +1000, Dave Chinner wrote:
> > +	/*
> > +	 * Grow can change the device size.  Mirror that into the buftarg.
> > +	 */
> > +	mp->m_ddev_targp->bt_nr_blocks = mp->m_sb.sb_dblocks;
> > +	if (mp->m_rtdev_targp && mp->m_rtdev_targp != mp->m_ddev_targp)
> > +		mp->m_rtdev_targp->bt_nr_blocks = mp->m_sb.sb_dblocks;
>                                                               ^
> That's not right.

Indeed.  It reverts us to the current state without this patch if
someone does a growfs :)

> Perhaps we need some growfs crash/recovery tests to exercise this
> code....

This code is exercises by the RT/zoned growfs tests.  However as the
only RT metadata buffer is at block 0 nothing will notice a wrong
value here (which is also the reason why the current state of this
that hardcodes the sb_dblocks check actually works).





[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux