Re: xfsdump musl patch questions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Aug 30, 2025 at 06:23:36AM -0500, Adam Thiede wrote:
> Hello - I'm interested in packaging xfsdump for alpine linux. However,
> alpine uses musl libc and I had to change a lot of things to get xfsdump to
> build. Mostly it was changing types that are specific to glibc (i.e. stat64
> -> stat). I'm not much of a c programmer myself so I am likely
> misunderstanding some things, but changing these types allows xfsdump to
> compile and function on musl libc. xfsdump still compiles on Debian with
> this patch too.
> 
> Would the maintainers of xfsdump be interested in this patch? It's >4000
> lines so I'm not sure of the right way to send it. It's available in the
> following merge request, and linked directly.
> 
> https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/88452
> https://gitlab.alpinelinux.org/alpine/aports/-/raw/f042233eff197591777663751848ff504210002e/testing/xfsdump/musl.patch
> 

Using the proper LFS APIs instead of the *64 is a good thing, and
xfsprogs has done this long ago.  So in general patches are welcome,
but please split them into one issue per patch, maybe starting with
removing the *64 APIs.





[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux