On Wed, Sep 03, 2025 at 08:03:11AM +0200, Christoph Hellwig wrote: > On Tue, Sep 02, 2025 at 03:32:03PM -0700, Darrick J. Wong wrote: > > It's only needed in newbt.c. What if I change the commit message to: > > > > "xfs: remove static reap limits from repair.h > > > > "Delete XREAP_MAX_BINVAL and XREAP_MAX_DEFER_CHAIN because the reap code > > now calculates those limits dynamically, so they're no longer needed. > > > > "Move the third limit (XREP_MAX_ITRUNCATE_EFIS) to the one file that > > uses it. Note that the btree rebuilding code should reserve exactly the > > number of blocks needed to rebuild a btree, so it is rare that the newbt > > code will need to add any EFIs to the commit transaction. That's why > > that static limit remains." > > > > Would that make it clearer? > > Yes. With that: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Cool, thank you! --D
