On Wed, Sep 3, 2025 at 11:05 PM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > On Fri, Aug 29, 2025 at 04:56:14PM -0700, Joanne Koong wrote: > > Refactor the read/readahead completion logic into two new functions, > > iomap_readfolio_complete() and iomap_readfolio_submit(). This helps make > > iomap read/readahead generic when the code will be moved out of > > CONFIG_BLOCK scope. > > I'll have to look how this goes further down, but I don't really like > the idea of treating bios special in common code. I'd rather go down > the same route as for writeback and replace the bio with a generic > void pointer, and then either use callbacks to process them, or maybe > have multiple versions of iomap_read_folio / iomap_readfolio_complete > that just share the underlying iterator, but implement their own logic > around it. > That sounds good to me, I'll make that change for v2.
