Re: [PATCH] xfs: Select XFS_RT if BLK_DEV_ZONED is enabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/11/25 7:56 PM, Carlos Maiolino wrote:
> On Mon, Aug 11, 2025 at 12:50:07PM +0200, Christoph Hellwig wrote:
>> On Wed, Aug 06, 2025 at 09:46:58AM +0200, Carlos Maiolino wrote:
>>>> +	select XFS_RT if BLK_DEV_ZONED
>>>
>>> This looks weird to me.
>>> Obligating users to enable an optional feature in xfs if their
>>> kernel are configured with a specific block dev feature doesn't
>>> sound the right thing to do.
>>> What if the user doesn't want to use XFS RT devices even though
>>> BLK_DEV_ZONED is enabled, for whatever other purpose?
>>>
>>> Forcing enabling a filesystem configuration because a specific block
>>> feature is enabled doesn't sound the right thing to do IMHO.
>>
>> Yes.  What might be useful is to default XFS_RT to on for BLK_DEV_ZONED.
>> I.e.
>>
>> 	config XFS_RT
>> 		...
>> 		default BLK_DEV_ZONED
>> 		...
>>
>> That way we get a good default, but still allow full selection /
>> deselection.
> 
> This sounds a good compromise.

Indeed. I'll send a patch.


-- 
Damien Le Moal
Western Digital Research




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux