On Thu, Jul 31, 2025 at 06:15:58PM +0200, Christoph Hellwig wrote: > On Thu, Jul 31, 2025 at 08:59:41AM -0700, Darrick J. Wong wrote: > > > retry: > > > - WARN_ON(mp->m_super->s_writers.frozen == SB_FREEZE_COMPLETE); > > > tp = __xfs_trans_alloc(mp, flags); > > > + WARN_ON(mp->m_super->s_writers.frozen == SB_FREEZE_COMPLETE); > > > > Empty transactions can run during a freeze, so please put back the > > original warning and comment: > > Empty transactions don't end up in this code path any more. Oh, hah, silly me, I forgot that also got changed by that patchset. :( Reviewed-by: "Darrick J. Wong" <djwong@xxxxxxxxxx> --D