Re: [PATCH v11 1/1] proto: add ability to populate a filesystem from a directory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 30, 2025 at 08:26:52AM -0700, Darrick J. Wong wrote:
> On Wed, Jul 30, 2025 at 05:20:42PM +0200, Luca Di Maio wrote:
> > On Wed, Jul 30, 2025 at 08:04:09AM -0700, Darrick J. Wong wrote:
> > > On Wed, Jul 30, 2025 at 04:40:39PM +0200, Luca Di Maio wrote:
> > > > Thanks Darrick for the review!
> > > > Sorry again for this indentation mess, I'm going to basically align all
> > > > function arguments and all the top-function declarations
> > > > I was a bit confused because elsewhere in the code is not like that so
> > > > it's a bit difficult to infere
> > > >
> > > > Offtopic: maybe we could also introduce an editorconfig setup? so that
> > > > all various editors will be correctly set to see the tabs/spaces as
> > > > needed (https://editorconfig.org/)
> > >
> > > Hrmm, that /would/ be useful.
> > >
> >
> > Nice, will try to put something together for a future patch
>
> Either that or a indent/clang-format wrapper?

Yes that is what I was thinking, there should be the option to create
custom formatting rules, and stick with those, ideally with a pre-commit
hook

> The kernel has scripts/Lindent, maybe someone should try to write one
> for xfs style if I don't get to it first.

I'm unfamiliar with those, I'll try to check them in the next
days/weeks

L.




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux