Re: [PATCH] iomap: move prefaulting out of hot write path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jul 26, 2025 at 05:09:56PM +0800, alexjlzheng@xxxxxxxxx wrote:
> @@ -992,6 +977,12 @@ static int iomap_write_iter(struct iomap_iter *iter, struct iov_iter *i)
>  		if (mapping_writably_mapped(mapping))
>  			flush_dcache_folio(folio);
>  
> +		/*
> +		 * copy_folio_from_iter_atomic() short-circuits page fault handle
> +		 * logics via pagefault_disable(), to prevent deadlock scenarios
> +		 * when both source and destination buffers reside within the same
> +		 * folio (mmap, ...).
> +		 */

Why did you change this comment from the one in 665575cff098?
The comment in that commit is correct.  This comment is so badly
mangled, it isn't even wrong.





[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux