On Tue, Jul 22, 2025 at 7:56 AM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > I just noticed this test failing on zoned xfs in current for-next. > > That's because for out of place overwrite file systems writing at > ENOSPC will obviously fail, and I think the test acknowledges that > by forcing nocow for btrfs. > > But that leaves "real" out of place write file systems affected, which > should also include zone btrfs, but the test actually fails there > in mkfs already due to some reason. If the mkfs fails, it's probably _small_fs_size_mb that needs to be updated with a sane size for zoned btrfs. Johannes at Aota could give some advice there. > > Can you please rework the patch to see that setting the nocow flag > works first and only try with that or something like that? Reworking it is late as it's already in for-next, but we can add a patch to skip it on zoned xfs: 1) The quickest way would be to add to the test: _require_non_zoned_device $SCRATCH_DEV 2) Or add a "_require_nocow_data_writes" helper to check we can write in place and skip the test if not, as you suggest, as it's more generic in case there are other filesystems or configurations where data writes are always COWed.
