Re: [PATCH 5/7] xfs: replace min & max with clamp() in xfs_max_open_zones()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 5/7] xfs: replace min & max with clamp() in xfs_max_open_zones()
From: Alan Huang <mmpgouride@xxxxxxxxx>
Date: Thu, 17 Jul 2025 14:42:40 +0800
Cc: "Darrick J. Wong" <djwong@xxxxxxxxxx>, Carlos Maiolino <cem@xxxxxxxxxx>, Hans Holmberg <hans.holmberg@xxxxxxx>, linux-xfs@xxxxxxxxxxxxxxx, George Hu <integral@xxxxxxxxxxxxx>, John Garry <john.g.garry@xxxxxxxxxx>
In-reply-to: <20250717051619.GC27362@lst.de>
References: <20250716125413.2148420-1-hch@lst.de> <20250716125413.2148420-6-hch@lst.de> <20250716160206.GL2672049@frogsfrogsfrogs> <3B511F05-E1FB-4396-B91F-769678B8E776@gmail.com> <20250717051619.GC27362@lst.de>

On Jul 17, 2025, at 13:16, Christoph Hellwig <hch@xxxxxx> wrote:
> 
> On Thu, Jul 17, 2025 at 12:52:14AM +0800, Alan Huang wrote:
>>> Does clamp() handle the case where @max < @min properly?
>> 
>> No, it only has BUILD_BUG_ON_MSG(statically_true(ulo > uhi), “xxx")
> 
> Well, I guess we'll just need to drop this patch then, right?
> 

Yeah, I think so.

References:
- misc zoned allocators fixes and cleanups
  - From: Christoph Hellwig
- [PATCH 5/7] xfs: replace min & max with clamp() in xfs_max_open_zones()
  - From: Christoph Hellwig
- Re: [PATCH 5/7] xfs: replace min & max with clamp() in xfs_max_open_zones()
  - From: Darrick J. Wong
- Re: [PATCH 5/7] xfs: replace min & max with clamp() in xfs_max_open_zones()
  - From: Alan Huang
- Re: [PATCH 5/7] xfs: replace min & max with clamp() in xfs_max_open_zones()
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 5/7] xfs: replace min & max with clamp() in xfs_max_open_zones()
Next by Date: Re: [PATCH v7 0/6] block/md/dm: set chunk_sectors from stacked dev stripe size
Previous by thread: Re: [PATCH 5/7] xfs: replace min & max with clamp() in xfs_max_open_zones()
Next by thread: [PATCH 6/7] xfs: improve the comments in xfs_max_open_zones
Index(es):
- Date
- Thread

[Index of Archives] [XFS Filesystem Development (older mail)] [Linux Filesystem Development] [Linux Audio Users] [Yosemite Trails] [Linux Kernel] [Linux RAID] [Linux SCSI]