Hi all, I'm seeing assert failures in xfs/538 in for-next when using 1k file systems. Unfortunately the errors are a bit flakely, two days ago I had a streak where I could reproduce them pretty easily and the bisection landed at: "xfs: refactor xfs_btree_diff_two_ptrs() to take advantage of cmp_int()" but trying to reproduce it again yesterday mostly failed, with just a single occurance of the failure in many runs. Below is the assert output, which suggests that xfs_bmapi_write gets something wrong in the accounting in case it rings a bell for someone: [ 6062.095597] XFS (vdc): Injecting error (false) at file fs/xfs/libxfs/xfs_bmap.c, line 3665, on filesystem "vdc" [ 6062.355716] XFS: Assertion failed: pathlen == 0, file: fs/xfs/libxfs/xfs_symlink_remote.c, line: 383 [ 6062.356258] ------------[ cut here ]------------ [ 6062.356502] kernel BUG at fs/xfs/xfs_message.c:102! [ 6062.356761] Oops: invalid opcode: 0000 [#1] SMP NOPTI [ 6062.357027] CPU: 1 UID: 0 PID: 1002774 Comm: fsstress Not tainted 6.16.0-rc2+ #1286 PREEMPT(full) [ 6062.357481] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 [ 6062.358024] RIP: 0010:assfail+0x2c/0x35 [ 6062.358229] Code: 1f 00 49 89 d0 41 89 c9 48 c7 c2 f0 2a 1a 83 48 89 f1 48 89 fe 48 c7 c7 8f 47 24 83 e8 fd fd ff ff 80 3d 1e 57 a4c [ 6062.361574] RSP: 0018:ffff8881d6a53c80 EFLAGS: 00010202 [ 6062.361951] RAX: 0000000000000000 RBX: ffff88813bb6ee80 RCX: 000000007fffffff [ 6062.362701] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffffffff8324478f [ 6062.363427] RBP: ffff8881026ee000 R08: 0000000000000000 R09: 000000000000000a [ 6062.363756] R10: 000000000000000a R11: 0fffffffffffffff R12: 000000000000001f [ 6062.364254] R13: 0000000000000001 R14: 00000000000003c8 R15: 00000000000003c8 [ 6062.364718] FS: 00007f6c9b5e1040(0000) GS:ffff8882b3418000(0000) knlGS:0000000000000000 [ 6062.365347] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 6062.365906] CR2: 00007f6c9b7df000 CR3: 00000001f456d005 CR4: 0000000000770ef0 [ 6062.366424] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 6062.366909] DR3: 0000000000000000 DR6: 00000000ffff07f0 DR7: 0000000000000400 [ 6062.367395] PKRU: 55555554 [ 6062.367593] Call Trace: [ 6062.367777] <TASK> [ 6062.367938] xfs_symlink_write_target+0x2c5/0x2d0 [ 6062.368282] ? xfs_diflags_to_iflags+0x14/0x100 [ 6062.368626] ? preempt_count_add+0x73/0xb0 [ 6062.368898] xfs_symlink+0x41d/0x520 [ 6062.369181] xfs_vn_symlink+0x8a/0x1b0 [ 6062.369446] vfs_symlink+0x10a/0x180 [ 6062.369765] do_symlinkat+0x104/0x130 [ 6062.370061] __x64_sys_symlink+0x32/0x40 [ 6062.370399] do_syscall_64+0x50/0x1d0 [ 6062.370659] entry_SYSCALL_64_after_hwframe+0x76/0x7e
