On Mon, Jul 14, 2025 at 06:23:01AM -0700, Christoph Hellwig wrote: > On Mon, Jul 14, 2025 at 09:20:59AM -0400, Brian Foster wrote: > > - error = xfs_free_file_space(XFS_I(inode), offset, len, ac); > > - if (error) > > - return error; > > + /* randomly force zeroing to exercise zero range */ > > This comment feels very sparse for this somewhat confusing behavior. > Can you add a shortened version of the commit message here explaining > why this is useful? > Sure, will fix. Brian > Otherwise looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> >