On Tue, Jul 08, 2025 at 03:38:10PM +0100, John Garry wrote: > On 01/07/2025 19:07, Darrick J. Wong wrote: > > From: Darrick J. Wong<djwong@xxxxxxxxxx> > > > > If mkfs declines to apply what it thinks is an overly large data device > > stripe unit to the log device, it should only log a message about that > > if the lsunit parameter was actually supplied by the caller. It should > > not do that when the lsunit was autodetected from the block devices. > > > > The cli parameters are zero-initialized in main and always have been. > > > > Cc:<linux-xfs@xxxxxxxxxxxxxxx> # v4.15.0 > > Fixes: 2f44b1b0e5adc4 ("mkfs: rework stripe calculations") > > Signed-off-by: "Darrick J. Wong"<djwong@xxxxxxxxxx> > > Makes sense, so FWIW: > > John Garry <john.g.garry@xxxxxxxxxx> Um.... is this a Reviewed-by: ? --D