Re: [PATCH v4 6/6] block: use chunk_sectors when evaluating stacked atomic write limits

[John Garry <john.g.garry@xxxxxxxxxx>]

On 08/07/2025 13:27, Nilay Shroff wrote:
> > +	if ((unsigned long)chunk_sectors << SECTOR_SHIFT > UINT_MAX)
> > +		chunk_bytes = chunk_sectors;
> > +	else
> > +		chunk_bytes = chunk_sectors << SECTOR_SHIFT;
> >   
> Can we use check_shl_overflow() here for checking overflow?

ok, I can change.

> Otherwise,
> changes look good to me. I've also tested it using my NVMe disk which
> supports up to 256kb of atomic writes.
> > Reviewed-by: Nilay Shroff<nilay@xxxxxxxxxxxxx>
> Tested-by: Nilay Shroff<nilay@xxxxxxxxxxxxx>

thanks