On Tue, Jul 1, 2025 at 12:04 AM Carlos Maiolino <cem@xxxxxxxxxx> wrote: > > On Mon, Jun 30, 2025 at 06:18:06PM +0530, Pranav Tyagi wrote: > > On Mon, Jun 30, 2025 at 5:49 PM Carlos Maiolino <cem@xxxxxxxxxx> wrote: > > > > > > On Tue, Jun 17, 2025 at 06:44:46PM +0530, Pranav Tyagi wrote: > > > > Use memcpy() in place of strncpy() in __xfs_xattr_put_listent(). > > > > The length is known and a null byte is added manually. > > > > > > > > No functional change intended. > > > > > > > > Signed-off-by: Pranav Tyagi <pranav.tyagi03@xxxxxxxxx> > > > > --- > > > > fs/xfs/xfs_xattr.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/fs/xfs/xfs_xattr.c b/fs/xfs/xfs_xattr.c > > > > index 0f641a9091ec..ac5cecec9aa1 100644 > > > > --- a/fs/xfs/xfs_xattr.c > > > > +++ b/fs/xfs/xfs_xattr.c > > > > @@ -243,7 +243,7 @@ __xfs_xattr_put_listent( > > > > offset = context->buffer + context->count; > > > > memcpy(offset, prefix, prefix_len); > > > > offset += prefix_len; > > > > - strncpy(offset, (char *)name, namelen); /* real name */ > > > > + memcpy(offset, (char *)name, namelen); /* real name */ > > > > offset += namelen; > > > > *offset = '\0'; > > > > > > What difference does it make? > > > > I intended this to be a cleanup patch as strncpy() > > is deprecated and its use discouraged. > > Fair enough. This is the kind of information that's worth > to add to the patch description on your future patches. > > No need to re-send this again. > > Reviewed-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx> Thanks Darrick and Carlos for the Reviewed-by tag. I also wanted to ask if this patch has been queued for merging. Regards Pranav Tyagi > > > > > Regards > > Pranav Tyagi > > > > > > > > > > > > > > -- > > > > 2.49.0 > > > >
