Key comparing routines are currently opencoded with extra casts and subtractions which is error prone and can be replaced with a neat cmp_int() helper which is now in a generic header file. Started from: https://lore.kernel.org/linux-xfs/20250426134232.128864-1-pchelkin@xxxxxxxxx/T/#u Thanks Darrick for suggestion! v1: https://lore.kernel.org/linux-xfs/20250612102455.63024-1-pchelkin@xxxxxxxxx/T/#u v2: tune 6/6 patch to rename the "diff_two_ptrs" part Fedor Pchelkin (6): xfs: rename diff_two_keys routines xfs: rename key_diff routines xfs: refactor cmp_two_keys routines to take advantage of cmp_int() xfs: refactor cmp_key_with_cur routines to take advantage of cmp_int() xfs: use a proper variable name and type for storing a comparison result xfs: refactor xfs_btree_diff_two_ptrs() to take advantage of cmp_int() fs/xfs/libxfs/xfs_alloc_btree.c | 52 +++++++++------------ fs/xfs/libxfs/xfs_bmap_btree.c | 32 +++++-------- fs/xfs/libxfs/xfs_btree.c | 33 +++++++------- fs/xfs/libxfs/xfs_btree.h | 41 +++++++++-------- fs/xfs/libxfs/xfs_ialloc_btree.c | 24 +++++----- fs/xfs/libxfs/xfs_refcount_btree.c | 18 ++++---- fs/xfs/libxfs/xfs_rmap_btree.c | 67 ++++++++++------------------ fs/xfs/libxfs/xfs_rtrefcount_btree.c | 18 ++++---- fs/xfs/libxfs/xfs_rtrmap_btree.c | 67 ++++++++++------------------ fs/xfs/scrub/btree.c | 2 +- fs/xfs/scrub/rcbag_btree.c | 38 +++++----------- 11 files changed, 158 insertions(+), 234 deletions(-) -- 2.50.0
