On Fri, Jun 27, 2025 at 03:18:25PM -0400, Brian Foster wrote: > > diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c > > index ff05e6b1b0bb..2e94a9435002 100644 > > --- a/fs/xfs/xfs_iomap.c > > +++ b/fs/xfs/xfs_iomap.c > > @@ -79,6 +79,9 @@ xfs_iomap_valid( > > { > > struct xfs_inode *ip = XFS_I(inode); > > > > + if (iomap->type == IOMAP_HOLE) > > + return true; > > + > > Is this to handle the xfs_hole_to_iomap() case? I.e., no validity cookie > and no folio_ops set..? If so, I think a small comment would be helpful. Yes, and I can add a comment.